Zaros Part 1
Zaros
DeFiFoundry
60,000 USDC
View results
Previous Next
Submission Details
Severity: medium
Invalid

Missing Check for Maximum Open Interest can cause open interest to surpass limit

tezeoffor

Summary

In the updateOpenInterest function, there is no check to ensure that the newOpenInterest does not exceed the maxOpenInterest. This omission could lead to the market's open interest surpassing the intended limit, potentially increasing risk and instability.

Vulnerability Details

Impact

Exceeding the maximum open interest can lead to excessive risk exposure and market instability, impacting the overall integrity of the trading platform.

Tools Used

Manual review

Recommendations

Implement the check within the updateOpenInterest function:

function updateOpenInterest(Data storage self, UD60x18 newOpenInterest, SD59x18 newSkew) internal {
require(newOpenInterest <= self.configuration.maxOpenInterest, "New open interest exceeds maximum allowed value");
self.skew = newSkew.intoInt256().toInt128();
self.openInterest = newOpenInterest.intoUint128();
}
​
Updates

Lead Judging Commences

inallhonesty Lead Judge
about 1 year ago
inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.