Submission Details
Severity:
Incorrect value of `REPORT_PRICE_DECIMALS` in BaseKeeper.sol
Summary
There is variable which indicates decimals of returned price from Data Streams:
https://github.com/Cyfrin/2024-07-zaros/blob/d687fe96bb7ace8652778797052a38763fbcbb1b/src/external/chainlink/keepers/BaseKeeper.sol#L18
/// @notice Chainlink Data Streams Reports default decimals (both Basic and Premium).
uint8 internal constant REPORT_PRICE_DECIMALS = 8;
Problem is that real precision is 18 instead of 8. Here on Chainlink docs you can check it
Impact
Currently this variable is not used, so only in future it'll have any impact.
Tools Used
Manual Review
Recommendations
Either remove it or set 18 instead of 8.
Updates
Prize pool breakdown
Total prize
60,000 USDC
nSLOC
2,87821 USDC / LOC
50,000 USDC
5,500 USDC
4,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.