Submission Details
Severity:
Wrong calculation of `managerCut` in `Pot::closePot`
Description:
In closePot function, the managerCut is calculated by dividing remainingRewards by managerCutPercent
instead of remainingRewards multiplying by managerCutPercent and then dividing by 100.
Impact:
Although it fortunately does not affect the result (the managerCut value), But it is computationally incorrect.
Tools Used:
Manual review.
Recommendations:
Change the calculation of managerCut in closePot.
- uint256 managerCut = remainingRewards / managerCutPercent;
+ uint256 managerCut = remainingRewards * managerCutPercent / 100;
Rewards breakdown
nSLOC
106This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.