Submission Details
Severity:
Distribution calculations on pot closing are wrong
Summary
The calculations to distribute the remaining funds equally among the claimants split it by the total number of players and not the number of claimants.
Vulnerability Details
Pot.sol, line 57, closePot():
uint256 claimantCut = (remainingRewards - managerCut) / i_players.length;
Rather than being divided by the length of the player array, it should be divided by the length of the claimants array.
Impact
It leaves rewards stuck in the contract permanently.
Tools Used
VSCode
Recommendations
Change i_players.lengthto claimants.length.
Updates
Lead Judging Commences
equious 9 months ago
Submission Judgement Published Assigned finding tags:
Incorrect distribution in closePot()
Rewards breakdown
nSLOC
106This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.