MyCut

First Flight #23
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: medium
Invalid

no check on address validity

Summary

no check on address validity

Vulnerability Details

in ContestManager.sol , lines 48-51. there is no check on address validity. function must check wether provided address is a valid pot or not

function getContestRemainingRewards(address contest) public view returns (uint256) {
// @audit check is needed
Pot pot = Pot(contest);
return pot.getRemainingRewards();
}

Impact

no impact in scope of this contracts , but it would not be safe for some other contract to use this function, because it can be easily manipulated

Tools Used

no tools , no **Homo habilis **

Recommendations

add check on address validity

Updates

Lead Judging Commences

equious Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.