MyCut

First Flight #23
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: medium
Invalid

No Check On `Pot` Status

Summary

The function ContestManager::fundContest() does not check whether the Pot has been closed or has enough assets.

Vulnerability Details

When the Owner calls ContestManager::fundContest() on a Pot that has been closed, then the Owner may lose assets because if the Owner tries to retrieve the assets from the Pot, the manager's cut is only 10% and the rest is distributed to the claimants.

The function ContestManager::fundContest() also does not check whether the Pot already has enough assets. It is not possible to retrieve a full amount of the assets.

Impact

The owner loses assets.

Tools Used

Manual review.

Recommendations

Consider adding checks on the Pot status to prevent the aforementioned problems.

Updates

Lead Judging Commences

equious Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Known issue

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.