MyCut

First Flight #23
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: low
Valid

Potential Unclaimable Remaining Reward From Rounding Error

Summary

If there is rounding error, the remaining reward may be unclaimable.

Vulnerability Details

Function Pot::closePot() distributes the remaining rewards based on a rule: remaining reward/10 to manager and the rest is equally distributed to claimants. If there is a small rounding error, then it is possible that calling closePot will transfer zero amount to the manager and all claimants, where the remaining rewards remains at the Pot contract.

Impact

Small amount of assets becomes unclaimable.

Tools Used

Manual review.

Recommendations

Consider transferring the remaining assets to an actor.

Updates

Lead Judging Commences

equious Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

Dusty Pot

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.