MyCut

Description

The Pot::claimCut function allows claimants to claim their rewards from the pot pool. However, the function lacks a check for the time constraints defined in the contest documentation. According to the documentation, claimants have a 90-day window to claim their rewards before the manager is entitled to take a cut of the remaining pool.

The current implementation does not verify whether the claim is being made within the allowed 90-day period. As a result, claimants can potentially claim their rewards even after the designated claim period has expired.

Impact

Claimants might claim rewards after the intended period, leading to disputes and incorrect reward distribution. Also the manager may not receive the correct cut of the remaining pool if late claims are permitted, resulting in potential financial discrepancies.

Tools Used

Manual review, vscode

Recommended Mitigation

To address this issue, a time check should be implemented within the Pot::claimCut function to ensure that claims are made within the authorized 90-day period: