MyCut

First Flight #23
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: low
Invalid

Declared and not used error `Pot::Pot__InsufficientFunds` should be reviewed

Summary

The custom error Pot::Pot__InsufficientFunds is declared but never used. It is advisable to review it to determine if it should be implemented, or if it should be commented out or deleted.

Vulnerability Details

In the line L9 of the contract Pot.sol it is noted that the error Pot__InsufficientFunds is declared as follows:

error Pot__InsufficientFunds();

However, is never actually being used in any of the contracts of the protocol.

Impact

This issue can lead to inadequate error handling and less informative error reporting, potentially obscuring issues and complicating maintenance. It may also indicate incomplete functionality.

Tools Used

Manual review

Recommendations

It is advisable to review the custom error Pot::Pot__InsufficientFunds to determine if it needs to be implemented, commented out, or removed.

Updates

Lead Judging Commences

equious Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.