Submission Details
Severity:
Gas Optimization Findings
Summary
The following findings are gas optimizations and have an informative impact. They are grouped this way because the same recommendation applies to all cases. Using .length in a loop is less efficient than using a constant, because otherwise, the code reads the array length each time it loops. It's better to store the length in memory:
Pot::constructor in initialization loop:
for (uint256 i = 0; i < i_players.length; i++) {
playersToRewards[i_players[i]] = i_rewards[i];
}
Pot::closePot
for (uint256 i = 0; i < claimants.length; i++) {
_transferReward(claimants[i], claimantCut);
}
Recommendations
Optimization for Pot::constructor:
+ uint256 playerLength = i_players.length;
+ for (uint256 i = 0; i < playerLength; i++) {
- for (uint256 i = 0; i < i_players.length; i++) {
playersToRewards[i_players[i]] = i_rewards[i];
}
Optimization for Pot::closePot:
+ uint256 claimantsLength = claimants.length;
+ for (uint256 i = 0; i < claimantsLength; i++) {
- for (uint256 i = 0; i < claimants.length; i++) {
_transferReward(claimants[i], claimantCut);
}
Rewards breakdown
nSLOC
106This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.