MyCut

Summary

The ContestManager contract lacks a mechanism to remove or manage the lifecycle of contests, leading to potential inefficiencies and storage bloat.

Vulnerability Details

Contests are stored indefinitely in the contests array without a removal mechanism and there are no means to differentiate between active and inactive contests.
Accumulation of inactive contests could lead to unforeseen vulnerabilities.

Impact

Unmanaged contests could be targeted in attacks or misuse. Also persistent storage of inactive contests increases gas costs for interactions.

Tools Used

Manual Review

Recommendation

Introduce a function to remove contests from the contests array. Also add states to contests (e.g., Active, Closed, Removed) and ensure proper state transitions.