MyCut

First Flight #23
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: low
Invalid

Unchecked External Call in 'fundContest'

Summary

The fundContest function calls token.transferFrom to transfer funds to the Pot contract but doesn't verify whether this call succeeds.

Impact

transfer funds to the Pot contract but doesn't verify whether this call succeeds.

Recommendations

Ensure that the external call to transferFrom checks for success

bool success = token.transferFrom(msg.sender, address(pot), totalRewards);
require(success, "Token transfer failed");
Updates

Lead Judging Commences

equious Lead Judge 12 months ago
Submission Judgement Published
Invalidated
Reason: Other

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.