Submission Details
Severity:
`public` functions not used internally could be marked `external`
Description: Instead of marking a function as public, consider marking it as external if it is not used internally in the ContestManager.sol and Pot.sol.
ContestManager.sol
function createContest(address[] memory players, uint256[] memory rewards, IERC20 token, uint256 totalRewards) public onlyOwner returns (address) {}
function getContests() public view returns (address[] memory) {
return contests;
}
function getContestTotalRewards(address contest) public view returns (uint256) {
return contestToTotalRewards[contest];
}
function getContestRemainingRewards(address contest) public view returns (uint256) {
Pot pot = Pot(contest);
return pot.getRemainingRewards();
}
Pot.sol
function getToken() public view returns (IERC20) {
return i_token;
}
function checkCut(address player) public view returns (uint256) {
return playersToRewards[player];
}
function getRemainingRewards() public view returns (uint256) {
return remainingRewards;
}
Rewards breakdown
nSLOC
106This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.