Submission Details
Severity:
Wrong calculation in `Pot.sol` for `claimantCut`
Summary
In the Pot.solthe calculation for claimantCutis wrongly calculated.
Vulnerability Details
The claimantCutshould be calculated like that uint256 claimantCut = (remainingRewards - managerCut) / claimants.length;but instead it is calculated like this uint256 claimantCut = (remainingRewards - managerCut) / i_players.length;.
Impact
This can lead to wrong calculated cuts and unintented behaviour.
Tools Used
Manual review
Recommendations
Change i_players.length to claimants.length.
Updates
Lead Judging Commences
equious about 1 year ago
Submission Judgement Published Assigned finding tags:
Incorrect distribution in closePot()
Rewards breakdown
nSLOC
106This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.