MyCut

Summary

In the function Pot::closePot() managerCutis not calculated properly

Vulnerability Details

managerCut calculates a fraction of remainingRewards and it's not the correct way to calculate the manager share. The manager takes a cut of the remaining pool, which is set to 10%. Calculation only works as intended when the percentage is 10%. Let's say the protocol decided that the manager's share would be 5% instead of 10%. In this case, this would give 20% instead of 5%.

Example

managerCutPercent = 10%

remainingRewards = 100,000

managerCut = 100000 / 10 => 10000

Correct but when managerCutPercent = 5%

managerCut= 100000 / 5 => 20000 which is not 5%, should be 5000

Impact

The manager cut will be incorrect if managerCutPercent is intended to be a different percentage.

Tools Used

Manual review

Recommendations