MyCut

First Flight #23
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: low
Valid

Missing Events For Critical Actions

Summary

Some functions are missing emitted events for critical state changes, which impairs the ability to track these updates off-chain.

Vulnerability Details

It has been observed that critical functionality is missing emitting event in ContestManager.sol and Pot.sol contracts. These affected functions should emit events after completing the transactions or afre contract state is beong changed. The following functions do not emit any events:

  • claimCut()

  • closePot()

  • fundContest()

Impact

Users are not able to follow the contract state.

Tools Used

Manual review

Recommendations

Consider emitting an event when calling setFeeManager and setTokenAllowed functions.

Updates

Lead Judging Commences

equious Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

Missing Events

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.