MyCut

First Flight #23
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: medium
Invalid

The manager can close the pot multiple times and receive the managerCut each time

Summary

If remainingRewards - managerCut < i_players.length and managerCut > 0, the manager can call the closePot function multiple times and receive the managerCut multiple times.

Impact

The pot can be closed multiple times, allowing the manager to repeatedly collect the managerCut.

Recommendation

If remainingRewards - managerCut < i_players.length, transfer all remainingRewards to the manager, because claimants can't receive less than 1 token. After closing the Pot, update the remainingRewards to 0.

Updates

Lead Judging Commences

equious Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Other

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.