Submission Details
Severity:
There is no check for `i_players.length != i_rewards.length` in the `Pot` constructor
Summary
The manager could accidentally send arrays of players and rewards with different lengths.
Impact
If this happens, the creation of the Pot would result in an error.
Recommendation
Add a require check at the beginning of the constructor:
+ error Pot__PlayersAndRewardsNotSameLength();
constructor(address[] memory players, uint256[] memory rewards, IERC20 token, uint256 totalRewards) {
+ if (i_players.length != i_rewards.length) revert Pot__PlayersAndRewardsNotSameLength();
...
}
Rewards breakdown
nSLOC
106This contest has a flat reward structure with the following payouts:
100 EXP
20 EXP
2 EXP
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.