MyCut

Summary

The constructor in Pot.sol does not handle duplicate players in the input array, which can lead to reward distribution discrepancies.

Vulnerability Details

In the Pot contract’s constructor, duplicate player entries in the input array are only counted once. This could cause issues in cases where multiple entries for the same player are expected.

Impact

Players might expect multiple rewards based on their multiple entries but will only receive one, potentially causing disputes.

Tools Used

Manual code review.

Recommendations

Either prevent duplicate entries or update the logic to handle multiple entries for the same player to ensure appropriate reward distribution.