MyCut

Summary

The Pot contract constructor lacks a check to ensure that the players and rewards arrays have the same length, which can lead to reward mismatches.

Vulnerability Details

The constructor of the Pot contract takes in two arrays: players and rewards. There is no check to ensure that both arrays are of equal length, which could result in rewards being improperly assigned to players.

Impact

A mismatch in the lengths of the players and rewards arrays could cause incomplete or incorrect reward distribution.

Tools Used

Manual code review.

Recommendations

Add a check at the start of the constructor to ensure the two arrays have the same length: