MyCut

First Flight #23
Beginner FriendlyFoundry
100 EXP
View results
Submission Details
Severity: low
Invalid

Incorrect Manager Cut Calculation:

Summary

The manager's cut of the remaining rewards is incorrectly calculated due to a faulty formula in the closePot function.

Vulnerability Details

In the closePot function, the formula remainingRewards / managerCutPercent is used to calculate the manager's cut. This doesn't give the manager exactly 10% of the remaining rewards but an unintended fraction.

Impact

The manager will receive less or more than the intended 10%, leading to a misdistribution of rewards.

Tools Used

Manual review

Recommendations

uint256 managerCut = (remainingRewards * managerCutPercent) / 100; // Correct formula

Updates

Lead Judging Commences

equious Lead Judge about 1 year ago
Submission Judgement Published
Validated
Assigned finding tags:

Erroneous ManagerCut calculation

Appeal created

equious Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Other

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.