Summary

suggest using basis points to represent managerCutPercent

Vulnerability Details

In Solidity, using basis points (bps) to represent percentages is a common practice to avoid precision issues associated with floating-point arithmetic. Solidity does not support floating-point operations, so all calculations must be done using integers. Basis points provide a way to represent fractional percentages using integers.

Using Basis Points

1. Higher Precision: Using basis points allows for representing smaller percentages (e.g., 0.01% is represented as 1 basis point), providing higher precision.

2. Avoids Rounding Errors: Since basis points use integer representation, it avoids rounding errors associated with floating-point arithmetic.

In Pot.sol,themanagerCutPercent doesn’t Using Basis Points, It makes if the remainingRewards < 10, the managerCut will be 0, so in this situation the contestManager will not get the any Cut.

Impact

Tools Used

manual

Recommendations

In Pot.sol, change the managerCutPercent represent.