MyCut

Summary

The codebase lacks the emission of critical events during important actions across both contracts. The absence of these events can lead to difficulties in monitoring and troubleshooting the contract's behavior, and it can obscure important state transitions from off-chain systems.

Vulnerability Details

Events are a fundamental part of smart contract design, serving as a log of important actions and state changes within the contract.

However, in the following sections of the codebase, some relevant actions occur without the emission of events:

1. Creating contests

2. Funding contests

3. Claiming a reward

4. Closing the contest

Impact

The absence of event emissions on critical state changes can lead to several issues, such as reduced transparency, incompatability with off-chain systems and potential for disputes. In absence of clear logs provided by events, it is hard to track any important activities or state changes in the decenetralized application.

Tools Used

Manual code review

Recommendations

It is recommended to introduce events for all critical state-changing, or any other important actions within the contracts.