Submission Details
Severity:
The `claimReward()` returns a misleading `(0, 0)`
Summary
The claimReward() returns a misleading (0, 0) for (uint256 rewardAmount, uint256 penaltyAmount) for a non early claim.
Vulnerability Details
The rewardAmount should be the ud.unclaimedRewards instead of zero if _isClaimEarly is false:
File: FjordStaking.sol
635: if (!_isClaimEarly) {
636: claimReceipts[msg.sender] =
637: ClaimReceipt({ requestEpoch: currentEpoch, amount: ud.unclaimedRewards });
638:
639: emit ClaimReceiptCreated(msg.sender, currentEpoch);
640:
641:>> return (0, 0);
642: }
Impact
The claimReward() returns zero for rewardAmount for a non early claim.
Recommendations
- return (0, 0);
+ return (ud.unclaimedRewards, 0);
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
66230 USDC / LOC
16,000 USDC
2,500 USDC
1,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.