Fjord Token Staking
Fjord
DeFiFoundry
20,000 USDC
View results
Previous Next
Submission Details
Severity: medium
Invalid

Missing Input Validation in FjordAuctionFactory.sol::createAuction()

sidhack3r11

Summary

The createAuction() function lacks validation for key inputs such as auctionToken, biddingTime, and totalTokens. This could result in faulty auction contracts being created with invalid parameters.

Vulnerability Details

The function allows for the creation of auctions without verifying that auctionToken is a valid address, or that biddingTime and totalTokens are non-zero values. Passing invalid values could cause the contract to behave unexpectedly

Impact

Deploying auction contracts with invalid parameters can result in broken or non-functional auctions. Users may waste gas deploying faulty contracts or participate in auctions that do not work as expected, leading to potential economic loss.

Tools Used

Manual Review

Recommendations

Add validation checks to ensure:

  • auctionToken is not address(0).

  • biddingTime and totalTokens are greater than zero.

Example validation:

if (auctionToken == address(0)) revert InvalidAddress();
if (biddingTime == 0 || totalTokens == 0) revert InvalidInput();
​
Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.