Fjord Token Staking

Summary

https://github.com/Cyfrin/2024-08-fjord/blob/main/src/FjordPoints.sol

The distributePoints() function may not handle timing accurately if called after multiple epochs have passed, potentially resulting in incorrect calculations.

Vulnerability Details

The function increments lastDistribution based on weeksPending, which might not align perfectly with real-time elapsed, leading to inaccurate point calculations if there is a significant delay between function calls.

Impact

Inaccurate timing updates can lead to incorrect pointsPerToken calculations and unfair distribution.

Proof of Concept (PoC):

Tools Used

Manual Review

Recommendations

Directly set lastDistribution to block.timestamp for accurate timing: