Submission Details
Severity:
`FjordAuction::constructor` missing input checks
Summary
FjordAuction::constructor missing input checks
Vulnerability Details
FjordAuction::constructor is missing input checks for _biddingTimeand _totalTokens
Impact
biddingTime=0or totalTokens=0will make created auction useless
Tools Used
Manual review
Recommendations
Add input checks to constructor
constructor(
address _fjordPoints,
address _auctionToken,
uint256 _biddingTime,
uint256 _totalTokens
) {
if (_fjordPoints == address(0)) {
revert InvalidFjordPointsAddress();
}
if (_auctionToken == address(0)) {
revert InvalidAuctionTokenAddress();
}
+ if(_biddingTime < MIN_BIDDING_TIME){
+ revert TooShortBiddingTime();
+ }
+ if(_totalTokens < MIN_TOKENS_AMOUNT){
+ revert NotEnoughTokensForDistribution();
+ }
fjordPoints = ERC20Burnable(_fjordPoints);
auctionToken = IERC20(_auctionToken);
owner = msg.sender;
auctionEndTime = block.timestamp.add(_biddingTime);
totalTokens = _totalTokens;
}
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
66230
USDC / LOC
16,000 USDC
2,500 USDC
1,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.