Fjord Token Staking

Summary

FjordStaking.sol::ClaimReward(bool) penaltyAmount gives inaccurate penalty when dividing.

Vulnerability Details

The division operator in solidity for thepenaltyAmount variable gives integer result. There is a chance of off-by-one error when the rewardAmountis odd.

Impact

The user will not get exactly 50% by losing 1 amount of reward every operation when the rewardAmount is an odd number.

Tools Used

None

Recommendations

Give an exclusive formula for rewardAmountwhenever the rewardAmountis odd or make sure that rewardAmountwill never be odd.