DeFiFoundry
20,000 USDC
View results
Submission Details
Severity: low
Invalid

the users can bid and unbid 0 amount for many time

Summary

the users can bid and unbid 0 amount as much as they like

Vulnerability Details

see that the following function cane take 0 as an amount without ani checks for that

https://github.com/Cyfrin/2024-08-fjord/blob/0312fa9dca29fa7ed9fc432fdcd05545b736575d/src/FjordAuction.sol#L143C1-L153C6

https://github.com/Cyfrin/2024-08-fjord/blob/0312fa9dca29fa7ed9fc432fdcd05545b736575d/src/FjordAuction.sol#L159C1-L176C6

Impact

  1. the amount of fjordPoints should never be 0

  2. event that containes 0 values will be emited every time

Tools Used

manual Review

Recommendations

ad checks for 0 amount

Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.