Submission Details
Severity:
`public` Functions Not Used Internally Could Be Marked `external`
Summary
Using proper visibility modifiers is a good practice to prevent unintended access to functions. Furthermore, marking functions as external instead of public can save gas.
Impact
None
File: src/FjordStaking.sol
339: function getStreamData(address _user, uint256 _streamID) public view returns (NFTData memory) {
343: function getStreamOwner(uint256 _streamID) public view returns (address) {
Tools Used
Aderyn
Recommendations
Consider changing the visibility modifier to external for the functions that are not used internally.
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
66230 USDC / LOC
16,000 USDC
2,500 USDC
1,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.