DeFiFoundry
20,000 USDC
View results
Submission Details
Severity: low
Invalid

`public` Functions Not Used Internally Could Be Marked `external`

Summary

Using proper visibility modifiers is a good practice to prevent unintended access to functions. Furthermore, marking functions as external instead of public can save gas.

Impact

None

File: src/FjordStaking.sol

339: function getStreamData(address _user, uint256 _streamID) public view returns (NFTData memory) {

343: function getStreamOwner(uint256 _streamID) public view returns (address) {

Tools Used

Aderyn

Recommendations

Consider changing the visibility modifier to external for the functions that are not used internally.

Updates

Lead Judging Commences

inallhonesty Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.