Fjord Token Staking

Summary

In several protected functions throughout the codebase, several key functions that modify the state of the contract, don't emit events, and the absence of events could lead to issues in tracking and auditing contract behavior, especially in complex systems that rely on these events for transparency, accountability, user notifications, etc.

Vulnerability Details

The following functions perform critical administrative operations that change the state of the contract. However, they fail to emit the expected events typically used to record these operations on the blockchain.

• FjordAuctionFactory.sol#L41

• FjordPoints.sol#L184

• FjordPoints.sol#L172

• FjordPoints.sol#L163

• FjordStaking.sol#L347

• FjordStaking.sol#L352

• FjordStaking.sol#L357

• FjordStaking.sol#L361

Impact

The absence of these events could lead to significant issues, such as:

• Lack of transparency in contract operations.

• Difficulty in debugging or auditing the contract.

• Reduced ability for external systems or users to respond to state changes within the contract.

• In the absence of proper event logs, it becomes easier for malicious actors to carry out activities without detection, potentially leading to exploits or fraudulent activities.

Tools Used

• Manual code review

Recommendations

For each identified function, implement the necessary event emissions to properly log state changes in the contract.