Fjord Token Staking

Summary

This finding focusses on the security of an ERC20 smart contract's the transfer functionalities

Vulnerability Details

ERC20 implementations are not always consistent. Some implementations of transfer and transferFrom could return ‘false’ on failure instead of reverting. It is safer to wrap such calls into require() statements to these failures. Unsafe transfer and transferFrom calls were found in the following locations:

• FjordAuctionFactory.sol#L63

• FjordAuction.sol#L151

• FjordAuction.sol#L174

• FjordAuction.sol#L193

• FjordAuction.sol#L220

Impact

Some of the tokens do not revert on failed transfer and transferFrom calls which could lead to funds insolvency.

Tools Used

• Manual review

Recommendations

Consider using OpenZepplin's safeTransfer and safeTransferFrom functions.