DeFiFoundry
20,000 USDC
View results
Submission Details
Severity: medium
Invalid

Excessive Owner Control Over Auction Process

Vulnerability Details:

The contract gives the owner significant control over the auction, including the ability to end it prematurely through the auctionEnd() function, which is not time-locked.

Impact:

This centralization of power could potentially be abused to manipulate auction outcomes, undermining trust in the system and potentially causing financial losses to participants.

Proof of Concept:

Link to code

function auctionEnd() external {
if (block.timestamp < auctionEndTime) {
revert AuctionNotYetEnded();
}
if (ended) {
revert AuctionEndAlreadyCalled();
}
ended = true;
// ... rest of the function ...
}

The owner could call this function as soon as block.timestamp >= auctionEndTime, potentially ending the auction earlier than participants expect.

Tools Used: Manual review

Recommendations

  • Implement a time-lock mechanism for sensitive owner actions.

  • Consider a decentralized governance model for critical decisions.

  • Add events to log all owner actions for transparency.

Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.