Fjord Token Staking
Fjord
DeFiFoundry
20,000 USDC
View results
Previous Next
Submission Details
Severity: low
Invalid

Missing Event Emission in FjordAuctionFactory::setOwner

heim

Summary

The setOwner function in the FjordAuctionFactory contract is missing an event emission mechanism when the owner is updated. Event emissions are critical for tracking contract state changes off-chain and ensuring transparency for stakeholders.

Vulnerability Details

The function updates the owner without emitting an event. This lack of notification makes it difficult to track changes to the contract's state off-chain. Event emissions are a standard best practice in Solidity to inform external systems of state changes, aiding in transparency and trust.

Location

  • setOwner function in the FjordAuctionFactory contract:

    function setOwner(address _newOwner) external onlyOwner {
    if (_newOwner == address(0)) revert InvalidAddress();
    owner = _newOwner;
    }

Impact

Low Severity: Affects off-chain monitoring, making state changes less transparent for auditors and stakeholders

Tools Used

Manual Code Review

Recommendations

Emit an OwnerUpdated event inside the setOwner function to enhance transparency:

+ event OwnerUpdated(address indexed previousOwner, address indexed newOwner);
​
function setOwner(address _newOwner) external onlyOwner {
if (_newOwner == address(0)) revert InvalidAddress();
+ emit OwnerUpdated(owner, _newOwner);
owner = _newOwner;
}
​
Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.