Submission Details
Severity:
Uncessary redundant code
Vulnerability Details
https://github.com/Cyfrin/2024-08-fjord/blob/0312fa9dca29fa7ed9fc432fdcd05545b736575d/src/FjordStaking.sol#L412
Impact
In FjordStaking.sol#L412 - #415, The code can be improved to remove redundancy and readability.
Tools Used
Manual Review
Recommendations
Remove this redundant code to improve readability/maintainability. Also checking if the amount is less code zero is uncessary cause it is an unsigned interger, so therefore it will automatically revert if the amount is less than zero
- if (depositedAmount - (withdrawnAmount + refundedAmount) <= 0) revert InvalidAmount();
uint256 _amount = depositedAmount - (withdrawnAmount + refundedAmount);
if (amount == 0) revert InvalidAmount();
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
66230
USDC / LOC
16,000 USDC
2,500 USDC
1,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.