DeFiFoundry
20,000 USDC
View results
Submission Details
Severity: low
Invalid

Functions with token transfer operations do not using `SafeTransferLib

Summary

Functions with token transfer operations does not using `SafeTransferLib

Vulnerability Details

All token transfer operations within `FjordStaking` contract already utilize SafeTransferLib. However, token transfer operations in `FjordAuction` contract functions like those in `bid`,`unbid`,`auctionEnd`,`claimTokens` and `AuctionFactory` contract function like `createAuction` still use the unsafe transfer method. Consider adjusting these transfer operations to also utilize SafeTransferLib.

Impact

Token which do not revert or return a boolean on failed transfer might fail silently, which will affect token accounting in contract

Tools Used

Manual Review

Recommendations

Consider using SafeTransferLib.safeTransfer() to handle such tokens. Just as used in token transfer operations within `FjordStaking`
Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Known issue

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.