Fjord Token Staking

Summary

The ERC20 functions may not consistently perform as intended, particularly with regard to the reliability of return values.

Vulnerability Details

On file path: 2024-08-fjord/src/FjordAuction.sol Line: 151, transferFrom is used to transfer FjordPoints from msg.sender to address(this) at a predetermined amount. This can be problematic if the call doesn't react as intended.

Impact

###Safety Checks:
transferFrom transfers fjordPoints from one address to another without performing any additional checks. It assumes that the recipient address can handle the fjordPoints.

###Reverting on Failure:
If the recipient address is a contract that does not implement the required interface, the tokens might be locked or lost, as transferFrom does not revert the transaction.

Tools Used

Aderyn

Recommendations

We recommend utilizing OpenZeppelin's SafeERC20 library for better safety measures.