there is no explicit handling of penalties or redistribution of penalized amounts to other stakers.
This means that the penaltyAmount, instead of being reused or reallocated
within the contract, simply reduces the total available
rewards (totalRewards).https://github.com/Cyfrin/2024-08-fjord/blob/0312fa9dca29fa7ed9fc432fdcd05545b736575d/src/FjordStaking.sol#L650-L651As a result,
the penalized amount are essentially "lost" and not redistributed
or used elsewhere,
which might not be the intended behavior
This could lead to a faster-than-expected depletion
of the reward amount, especially if multiple users claim early and penalties
are applied often.
Manual code review
Add a function to redistribute penalties amount to remaining stakers.
The contest is live. Earn rewards by submitting a finding.
This is your time to appeal against judgements on your submissions.
Appeals are being carefully reviewed by our judges.