DeFiFoundry
20,000 USDC
View results
Submission Details
Severity: medium
Invalid

Possibility to create an auction that lasts for many years

Summary

A user might accidentally create an auction using function "createAuction" w kontrakcie FjordAuctionFactory.solthat lasts for many years. This is due to the lack of proper input validation.

Vulnerability Details

A user might accidentally create an auction that lasts for many years. This is due to the lack of proper input validation.

https://github.com/Cyfrin/2024-08-fjord/blob/0312fa9dca29fa7ed9fc432fdcd05545b736575d/src/FjordAuctionFactory.sol#L52

Impact

A user by mistake can create an auction that lasts for many years, freezing their funds in the process.

POC

uint256 public biddingTime = type(uint256).max - 1; // or 0 value
function testNewAuction() public {
new FjordAuction(address(fjordPoints), address(auctionToken), biddingTime, totalTokens);

Tools Used

Manual Review, Foundry

Recommendations

Input validation should be applied to all values received from the users.

Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.