DeFiFoundry
20,000 USDC
View results
Submission Details
Severity: low
Invalid

FjordStaking doesn't check if a Fjord stream is cancelable

Summary

In FjordStaking in the stakeVested() there is a comment that says:
"only allow authorized stream sender to stake cancelable stream"

The stakeVested(), however, doesn't check to see if the stream is cancelable or not.

Sablier provides a function, isCancelable(), that allows the caller to see if a given stream can be canceled

Vulnerability Details

see summary

Impact

A customer can stake a canceled stream

Code Location

https://github.com/Cyfrin/2024-08-fjord/blob/main/src/FjordStaking.sol#L402C9-L403C13

Recommendations

Use the isCancelable() from Sablier to check if a stream can be cancelled or not

Updates

Lead Judging Commences

inallhonesty Lead Judge about 1 year ago
Submission Judgement Published
Invalidated
Reason: Incorrect statement

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.