Fjord Token Staking

Summary

addReward function emits a RewardAdded event with a potentially outdated epoch number which causes misleading event logs.

Vulnerability Details

Take a look athe the addReward function

As seen above, the current epoch is stored in a variable previousEpoch before calling _checkEpochRollover(). The RewardAdded event is then emitted using this previousEpoch value. IF an epoch rollover occurs during the execution of _checkEpochRollover(), the emitted event will contain an outdated epoch number that doesn't accurately reflect when the reward was added.

Impact

Misleading event logs.

Tools Used

Manual

Recommendations

Update the addReward function to emit the RewardAdded event with the current epoch after the potential rollover. To ensure that the event always contains the accurate epoch number.