Fjord Token Staking

Description

The following functions in the Fjord contracts lack event emissions, making it difficult to track critical changes, such as ownership updates, off-chain:

• AuctionFactory.setOwner(address) (src/FjordAuctionFactory.sol#43-47)

  • Should emit an event when the owner is updated (owner = _newOwner, src/FjordAuctionFactory.sol#46).

• FjordPoints.setOwner(address) (src/FjordPoints.sol#163-167)

  • Should emit an event when the owner is updated (owner = _newOwner, src/FjordPoints.sol#166).

• FjordPoints.setStakingContract(address) (src/FjordPoints.sol#173-180)

  • Should emit an event when the staking contract is updated (staking = _staking, src/FjordPoints.sol#179).

• FjordStaking.setOwner(address) (src/FjordStaking.sol#350-353)

  • Should emit an event when the owner is updated (owner = _newOwner, src/FjordStaking.sol#352).

• FjordStaking.setRewardAdmin(address) (src/FjordStaking.sol#355-358)

  • Should emit an event when the reward admin is updated (rewardAdmin = _rewardAdmin, src/FjordStaking.sol#357).

These functions do not currently emit any events, making it challenging to monitor important access control changes off-chain.

Recommendation

Add event emissions for all critical parameter changes to improve transparency and off-chain tracking.