DeFiFoundry
20,000 USDC
View results
Submission Details
Severity: low
Invalid

Lack of event emission after modifying `setOwner` function

Summary

In FjordAuctionFactory::setOwner function new owner is being set, but no events are being triggered.

This means that there will be no record of the changes in the Owner variable and traceability of the potential new owners will be lost.

Vulnerability Details

Impact

None

Tools Used

Manual Review

Recommendations

Consider defining an event for tracking the Owner variable value, and emit an event each time it is modified.

+ event NewOwnerSet(address indexed newOwner);
function setOwner(address _newOwner) external onlyOwner {
if (_newOwner == address(0)) revert InvalidAddress();
owner = _newOwner;
+ emit NewOwnerSet(newOwner);
}
Updates

Lead Judging Commences

inallhonesty Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.