DeFiFoundry
20,000 USDC
View results
Submission Details
Severity: low
Invalid

Missing events in functions that are either setters or privileged and setters.

Summary

Missing events in functions that are either setters or privileged.

Vulnerability Details

Setter functions which alter state variables without events been emitted in the functions, makes it hard for external observers or Dapps to track or react to these changes.

Number of Instances: 8

function setOwner in the FjordAuctionFactory.sol
https://github.com/Cyfrin/2024-08-fjord/blob/0312fa9dca29fa7ed9fc432fdcd05545b736575d/src/FjordAuctionFactory.sol#L41-L44
function setOwner, setStakingContract and setPointsPerEpoch in FjordPoints.sol
https://github.com/Cyfrin/2024-08-fjord/blob/0312fa9dca29fa7ed9fc432fdcd05545b736575d/src/FjordPoints.sol#L163-L166
https://github.com/Cyfrin/2024-08-fjord/blob/0312fa9dca29fa7ed9fc432fdcd05545b736575d/src/FjordPoints.sol#L172-L178
https://github.com/Cyfrin/2024-08-fjord/blob/0312fa9dca29fa7ed9fc432fdcd05545b736575d/src/FjordPoints.sol#L184-L190
function setOwner, setRewardAdmin. addAuthorizedSablierSender and removeAuthorizedSablierSender in FjordStaking.sol
https://github.com/Cyfrin/2024-08-fjord/blob/0312fa9dca29fa7ed9fc432fdcd05545b736575d/src/FjordStaking.sol#L347-L350
https://github.com/Cyfrin/2024-08-fjord/blob/0312fa9dca29fa7ed9fc432fdcd05545b736575d/src/FjordStaking.sol#L352-L355
https://github.com/Cyfrin/2024-08-fjord/blob/0312fa9dca29fa7ed9fc432fdcd05545b736575d/src/FjordStaking.sol#L357-L359
https://github.com/Cyfrin/2024-08-fjord/blob/0312fa9dca29fa7ed9fc432fdcd05545b736575d/src/FjordStaking.sol#L361-L363

Impact

Impact is low as it does not directly affect workings of the protocol, but does obscure contract activity, hampering transparency and making integration more challenging.

Tools Used

Manual Analysis

Recommendations

It is imperative to incorporate appropriate event emissions within these functions. Events offer an efficient way to log crucial changes, aiding in real-time tracking and post-transaction verification.

Updates

Lead Judging Commences

inallhonesty Lead Judge 10 months ago
Submission Judgement Published
Invalidated
Reason: Non-acceptable severity

Support

FAQs

Can't find an answer? Chat with us on Discord, Twitter or Linkedin.