Fjord Token Staking

Summary

In FjordAuctionFactory.sol a user sends a salt to create a certain specific address. But a malicious user can read the mempool, frontrun the transaction and create auction with same salt. This will cause address collision and the genuine user transaction will revert.

Vulnerability Details

Only considering an element as salt that can be read from the mempool can cause DoS for genuine users as the malicious user will keep on creating addresses with same salt.
https://github.com/Cyfrin/2024-08-fjord/blob/main/src/FjordAuctionFactory.sol#L59

Impact

Leads the DoS for auction creators.

Tools Used

Vs Code

Recommendations

encode msg.sender address with the salt so a malicious user can't frontrun the transaction. Hence mitigating DoS possibility.