Submission Details
Severity:
If `_biddingTime` for an auction is 0 the auction becomes useless.
Summary
If FjordAuction contract is initiated with parameter _biddingTime = 0 then
the auction becomes inactive.
Vulnerability Details
Impact
A FjordAuctioncontract will become unusable if deployed with constructor parameter _biddingTime = 0. As bid() and unbid() will revert
after deployment.
Tools Used
Manual analysis.
Recommendations
Consider adding a check for a minimum amount of biddingTime on deployment of
FjordAuction.sol.
constructor(
address _fjordPoints,
address _auctionToken,
uint256 _biddingTime,
uint256 _totalTokens
) {
if (_fjordPoints == address(0)) {
revert InvalidFjordPointsAddress();
}
if (_auctionToken == address(0)) {
revert InvalidAuctionTokenAddress();
}
if (_biddingTime < MAX_BIDDING_TIME) {
revert InvalidBiddingTime();
}
fjordPoints = ERC20Burnable(_fjordPoints);
auctionToken = IERC20(_auctionToken);
owner = msg.sender;
auctionEndTime = block.timestamp.add(_biddingTime);
totalTokens = _totalTokens;
}
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
66230 USDC / LOC
16,000 USDC
2,500 USDC
1,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.