Submission Details
Severity:
Auction end conditional is biased. Limits users to bid.
Summary
The auction end conditional check implemented on FjordAuction::auctionEndto whether auction has ended or not has an ambiguity. The conditional block.timestamp < auctionEndTimeis limiting users to bid by one second.
Vulnerability Details
if (block.timestamp < auctionEndTime) {
---------------------^
revert AuctionNotYetEnded();
}
Impact
Restricts users to bid more by one second. Makes auction unfair.
Tools Used
Manual Review
Recommendations
Please improve the conditional check to equality too.
- if (block.timestamp < auctionEndTime) {
+ if (block.timestamp <= auctionEndTime) {
revert AuctionNotYetEnded();
}
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
66230 USDC / LOC
16,000 USDC
2,500 USDC
1,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.