Fjord Token Staking

Summary

The distributePoints() function is called indirectly through the checkDistribution modifier on various functions, including setPointsPerEpoch and claimPoints. This function updates the pointsPerToken and totalPoints based on the amount of time that has passed since the last distribution.

Vulnerability Details

• Manipulation of pointsPerToken: The pointsPerToken variable is updated based on the duration since the last distribution and the total staked tokens. If a malicious actor could manipulate this function's behavior, they could potentially issue excessive points to themselves or others, leading to unauthorized rewards.

• Control Over Point Distribution: Since distributePoints() can be triggered by other functions and updates global state, an attacker might exploit this function if they can manipulate the timing or call it inappropriately.

  https://github.com/Cyfrin/2024-08-fjord/blob/0312fa9dca29fa7ed9fc432fdcd05545b736575d/src/FjordPoints.sol#L232C1-L249C1

Impact

If an attacker can manipulate the point distribution

Tools Used

Recommendations

OR

Change the visibility of the distributePoints() function from public to internal or use another access control mechanism to ensure it can only be called under appropriate conditions, such as through an authorized function or by specific roles.