Submission Details
Severity:
SablierNfts may be locked in `FJordStaking` contract
Summary
The ERC721s may get stuck in the staking contract beacause of not supporting ERC721.
Vulnerability Details
On stakeVested(), staking contract receive Sablier ERC721 token from the Caller
sablier.transferFrom({ from: msg.sender, to: address(this), tokenId: _streamID });
It Uses `transferFrom()`
Most importantly according to EIP-721 standard
A wallet/broker/auction application MUST implement the wallet interface if it will accept safe transfers.
Reference :- https://eips.ethereum.org/EIPS/eip-721
But here Staking contract doesnot implemented anything such
Links
Tools Used
vsCode
Recommendations
Implement Support Interfaces as per mentioned in EIP-721 standard
function onERC721Received(address _operator, address _from, uint256 _tokenId, bytes _data) external returns(bytes4);
Use `safeTransfer` and `safeTransferFrom()`
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
66230 USDC / LOC
16,000 USDC
2,500 USDC
1,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.