Submission Details
Severity:
Unreachable incorrect check
Summary
The claimReward has an unreachable check. This can cause a false sense of invariant checking.
Vulnerability Details
The claimReceipts[msg.sender].requestEpoch >= currentEpoch - 1 condition can only be reached when claimReceipts[msg.sender].requestEpoch == 0.
function claimReward(bool _isClaimEarly)
external
checkEpochRollover
redeemPendingRewards
returns (uint256 rewardAmount, uint256 penaltyAmount)
{
//CHECK
UserData storage ud = userData[msg.sender];
>> // do not allow to claimReward while user have pending claimReceipt
>> // or user have claimed from the last epoch
if (
>> claimReceipts[msg.sender].requestEpoch > 0
>> || claimReceipts[msg.sender].requestEpoch >= currentEpoch - 1
) revert ClaimTooEarly();
if (ud.unclaimedRewards == 0) revert NothingToClaim();
//EFFECT
if (!_isClaimEarly) {
claimReceipts[msg.sender] =
>> ClaimReceipt({ requestEpoch: currentEpoch, amount: ud.unclaimedRewards });
emit ClaimReceiptCreated(msg.sender, currentEpoch);
return (0, 0);
}
Impact
Unexpected behavior
Tools used
Manual Review
Recommendations
Consider removing useless check
Prize pool breakdown
Total prize
20,000 USDC
nSLOC
66230 USDC / LOC
16,000 USDC
2,500 USDC
1,500 USDC
Live
The contest is live. Earn rewards by submitting a finding.
Appeals
This is your time to appeal against judgements on your submissions.
Appeals Review
Appeals are being carefully reviewed by our judges.